Yury Bondarenko
Yury Bondarenko
@tdonohue @atarix83 I'm not super familiar with the Docker setup, but it seems like it involves a `yarn install` with only `package.json` & `yarn.json`, so it's failing during the new...
@tdonohue I've addressed the issues with the new yarn scripts on Windows, so this should be ready to review again once https://github.com/DSpace/dspace-angular/issues/2977 is resolved
@tdonohue couldn't make Monday, hopefully today is still ok timing-wise.
Note: for the numbers above I compared `a8f31948bc9` and `41eccbbfe15`, the "potential gains" from splitting up `ListableModule` may be different after the Angular 16 upgrade
Just re-checked: `main.js` is ~600kB currently (down from ~670kB) But the potential size reductions from ↑ still apply.
Additional thoughts: * For this to work, we'll also need to update the selectors on component overrides in the actual themes * This will be reflected in the DOM, making...
Made a proof-of-concept branch by running the ZSH script below and cleaning up a few edge cases where the filenames did not match up correctly https://github.com/ybnd/dspace-angular/tree/poc-reverse-themed-component-selector-convenction ```zsh # Requirements: https://github.com/BurntSushi/ripgrep...
Here's a practical example: let's say we want to make the `ChipsComponent` themeable and add it to the `custom` theme #### Current process 1. Create a themed component wrapper *...
> If all institutions need to change the selectors (or ideally should), then we may need to consider updating the above script to be a yarn based tool...that way other...
@msutya sorry for the huge delay, but I think the problem you're referring to is not related to this PR, but to #2750 (tracked in https://github.com/DSpace/dspace-angular/issues/2898) A few of the...