Masafumi Koba

Results 705 comments of Masafumi Koba

`scripts/benchmark-rule.mjs` seems like a special use case for our internal use. 🤔 https://github.com/stylelint/stylelint/blob/b6e6a719e0e9924b60ca2b7fc1b989ab3e2f8a07/scripts/benchmark-rule.mjs#L9 https://github.com/stylelint/stylelint/blob/b6e6a719e0e9924b60ca2b7fc1b989ab3e2f8a07/scripts/benchmark-rule.mjs#L66 Have we documented to support this usage of `lib/rules/index.mjs`?

Yes, the benchmark script is documented, and so it should be fixed immediately. However, the script's implementation doesn't depend on the public API and is fragile. I guess this usage...

So, I'm still not sure if the original issue #8030 has the same problem as the benchmark's one.

Agree with @romainmenke. I've reverted the issue status. If there are no actions from the original reporter in a few weeks, I think we can close this.

@romainmenke Thanks for sharing your thoughts and explaining the problems. I realize finding an ideal API to support both autofix and `EditInfo` construction is challenging. As you pointed out, such...

Adding a utility sounds good to me. 👍🏼 If you have no big concerns, please open a pull request. If we don't like the function name so much, we can...

@emmacharp Thanks for the pull request. I've marked this PR as a draft to make our maintenance easier. Feel free to remove the draft state once you are ready. 🙏🏼

Ah, I missed your concern, sorry. I'll look at the direction later.

@emmacharp Generally speaking, I think a CLI flag should be prioritized over a configuration because CLI operations are usually easier than changing configuration files. E.g. ```jsonc // .stylelintrc.json { "formatter":...

Hum, currently, snapshot tests seem to be free of failures... I recommend first fixing the type errors. 😃