Yawar Amin

Results 110 comments of Yawar Amin

@ryyppy sure, I'll remove bsdoc from this PR. Nowadays I actually think it's better to do the doc generation part in a build step in CI and not have a...

OK, in that case I'd like to propose making a new `Fetch.Raw` module that has a 'zero-cost' style, and making the default `Fetch` module have the convenient wrapper over that....

I've been thinking of adding some API docs to ReasonReact. I can take a shot at this.

Thanks, I'll try to review soon. Just a note, that after the rescript-compiler PR merge, it will be published in BS 8.something). The problem is, that would require bs-webapi to...

@jfrolich Markdown support will land in Reason (I assume, at some point), but not in BuckleScript because BuckleScript is not upgrading its refmt version for the foreseeable future.

Based on what happened in https://github.com/BuckleScript/bucklescript/pull/4271 and then after that the new syntax being publicized, I assume they won't upgrade. And I don't see Markdown docs landing in the new...

AFAIK `appendObject` was intended only for React Native, it doesn't work for browsers. @FilipKittnar where are you running the output JS? In React Native? Can you show the exact error...

In Chrome at least there are no issues with: ```javascript var fd = new FormData() var bl = new Blob() fd.append('bl', bl, undefined) ```

No problem. As it turns out, we documented the issue with React Native in the interface file: https://github.com/reasonml-community/bs-fetch/blob/934389964e1005d4e37911c8324a6aeb7ce0a1b0/src/Fetch.mli#L260 . Maybe we should warn more explicitly there that it won't work...

I agree it's not ideal that people can create these objects with `maxDate`, `maxInt`, etc. but I think it's done for backward-compatibility. If we change the type of `max` it's...