bs-webapi-incubator
bs-webapi-incubator copied to clipboard
feat: add bindings for HTMLFormControlsCollection, HTMLOptionsCollection, RadioNodeList, etc
~~Needs to wait for https://github.com/rescript-lang/rescript-compiler/pull/4622 at the moment, so the 0.20 version is just placeholder~~
Not really sure how to proceed with the namedItem
binding, when I tried to put isRadioNodeList
into the Webapi__Dom__RadioNodeList
module, it gave me an error that the 'a
couldn't be generalized or something like that.
TODO:
- [x] write some smoke tests
- [x] undo ResizeObserver / ResizeObserverEntry t change for compat
Thanks, I'll try to review soon. Just a note, that after the rescript-compiler PR merge, it will be published in BS 8.something). The problem is, that would require bs-webapi to upgrade to 8.something to be able to use the new types introduced there. And BS 8+ has some backward-incompatible changes, which means upgrading to that version would prevent some folks from being able to upgrade bs-webapi. In the interim, I would recommend to introduce the types independently here and then later we can decide to alias them to the BS types for backward-compatibility.
Thanks, I'll try to review soon. Just a note, that after the rescript-compiler PR merge, it will be published in BS 8.something). The problem is, that would require bs-webapi to upgrade to 8.something to be able to use the new types introduced there. And BS 8+ has some backward-incompatible changes, which means upgrading to that version would prevent some folks from being able to upgrade bs-webapi. In the interim, I would recommend to introduce the types independently here and then later we can decide to alias them to the BS types for backward-compatibility.
Yeah I was thinking of that as well, just have the version to get it linked against my local rescript version for now.