Yash Mayya
Yash Mayya
@vrajat it looks like some unit tests in `DynamicBrokerSelectorTest` and `ExternalViewReaderTest` are failing due to this change.
I think this branch needs to be rebased / merged with `master`, all the builds are currently failing (at least one reason seems to be conflict with https://github.com/apache/pinot/pull/14294/).
I think that might be a good option given the proliferation of the different kinds of explain plans in Pinot. But we should probably discuss and come to a consensus...
Thanks @gortiz. `hadoop-client-runtime` was already added to the parent POM's dependency management section. I agree that adding `hadoop-client-api` explicitly as well and avoiding individual exclusions is a better solution overall...
> Chatting with Siddharth Dharm offline, who'd been trying this issue out. As per him this doesn't reproduce with these steps. I tried just now, and it indeed doesn’t reproduce...
Fixed in https://github.com/apache/pinot/pull/13598 / https://github.com/apache/pinot/pull/13955.
Duplicates https://github.com/apache/pinot/issues/12304?
Looks like this should be fixed by https://github.com/apache/pinot/pull/12878 in the upcoming Pinot 1.2.0 release. @francescomultari you can verify by running Pinot from the latest `master` branch (https://github.com/apache/pinot?tab=readme-ov-file#building-pinot).
Looks like a `QueryDispatcher` unit test is failing due to a missing expected cancellation
Thanks @gortiz! +1 to move away from GitBook, and I also strongly agree with maintaining the documentation alongside code in the same repo. I agree with markdown being the most...