Yash Mayya
Yash Mayya
@C0urante @tombentley could you please take a look at this simple bug fix?
Thanks for the review @C0urante and sorry about the late reply. That's a very astute observation regarding tasks potentially getting stuck in infinite loops - you're right in that the...
> I think a Supplier isCancelled would be fine to check if the operator should prematurely exit Makes sense, I've implemented this with a test. > One other thing worth...
Thanks @C0urante, that makes sense. I think we can maintain a `Map` in the `Worker` class (let's say `taskCancelLatch`) which gets populated in the task builder (with the `CountDownLatch` having...
>Why construct the latches in Worker? Wouldn't it be cleaner to create them in the RetryWithToleranceOperator constructor and expose a method in that class to count down the latch, which...
Thanks for the detailed reviews and for bearing with me through multiple rounds of review on this one Chris!
@C0urante would you be able to take a look at this whenever possible?
@C0urante another small PR for you to review whenever you get a chance? Thanks!
Thanks for the review Chris! > we already strongly advise against mutating record with SMTs (see [KAFKA-10720](https://issues.apache.org/jira/browse/KAFKA-10720) for detail), since that does have the potential to break things. Interesting, thanks...
@C0urante could you please take a look at this small change whenever you get a chance?