pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Revert "Use stats cache on error instead of the chained mechanism (#15992)"

Open gortiz opened this issue 1 month ago • 2 comments

This PR reverts #15992. We found some installations where the extra cancel call is more expensive than expected, especially because the server code executed during cancellation is quite costly. The long-term plan is to improve the server code, but right now it is safer not to call cancel that often

gortiz avatar Dec 02 '25 15:12 gortiz

Codecov Report

:x: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.24%. Comparing base (227de91) to head (66e91d1). :warning: Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../pinot/query/service/dispatch/QueryDispatcher.java 37.50% 4 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17305      +/-   ##
============================================
+ Coverage     63.23%   63.24%   +0.01%     
- Complexity     1474     1475       +1     
============================================
  Files          3152     3152              
  Lines        187870   187876       +6     
  Branches      28762    28764       +2     
============================================
+ Hits         118793   118831      +38     
+ Misses        59861    59832      -29     
+ Partials       9216     9213       -3     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.21% <37.50%> (+<0.01%) :arrow_up:
java-21 63.20% <37.50%> (+<0.01%) :arrow_up:
temurin 63.24% <37.50%> (+0.01%) :arrow_up:
unittests 63.24% <37.50%> (+0.01%) :arrow_up:
unittests1 55.67% <37.50%> (-0.01%) :arrow_down:
unittests2 33.88% <0.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 02 '25 16:12 codecov-commenter

Looks like a QueryDispatcher unit test is failing due to a missing expected cancellation

yashmayya avatar Dec 02 '25 22:12 yashmayya