Yan Zhu
Yan Zhu
Please add test for this change.
Please resolve CI failed items
Hi @AjKundnani, let me check with you some details: - Is the following filter still needed before setting `--security-type` default value with TrustedLaunch in Scenario 1? https://github.com/Azure/azure-cli/blob/bbdf30570f44fa5f1ea41ef072a78cfaeb633198/src/azure-cli/azure/cli/command_modules/vm/custom.py#L428-L431 - In the...
> @yanzhudd > > > * Is the following filter still needed before setting `--security-type` default value with TrustedLaunch in Scenario 1? > > https://github.com/Azure/azure-cli/blob/bbdf30570f44fa5f1ea41ef072a78cfaeb633198/src/azure-cli/azure/cli/command_modules/vm/custom.py#L428-L431 > > No, checking **features**...
> 2. If source OS image is Gen2 AND input `--hyper-v-generation` is **V1** then instead of printing notification message, apply `Trusted Launch defaults` - `--hyper-v-generation` = **V2**, `--security-type` = **TrustedLaunch**...
Got it! Thanks @AjKundnani :) BTW, the PR has been opened, could you please help review this [PR](https://github.com/Azure/azure-cli/pull/27620/files)?
Since there are multiple changes in this PR, please list them respectively with corresponding commands in the History Notes section. e.g., [AKS] `az aks create`: Add `--azure-monitor-private-link-scope-resource-id` optional parameter ...
please fix the linter issue of CI
please add test for this change and run it in live mode to verify if the change meets your expectations.
It is better to rerun some related tests in live mode to validate if the change meets your expectation.