azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[k8s-runtime] Make `k8s-runtime` stable

Open ddadaal opened this issue 1 year ago • 8 comments

Make k8s-runtime extension stable.

  1. Use stable api version 2024-03-01 for ARM APIs
  2. Remove preview tags for load-balancers and bgp-peers command groups

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

ddadaal avatar Apr 16 '24 06:04 ddadaal

❌Azure CLI Extensions Breaking Change Test
❌k8s-runtime
rule cmd_name rule_message suggest_message
1007 - ParaRemove k8s-runtime bgp-peer delete cmd k8s-runtime bgp-peer delete removed parameter no_wait please add back parameter no_wait for cmd k8s-runtime bgp-peer delete
1007 - ParaRemove k8s-runtime load-balancer delete cmd k8s-runtime load-balancer delete removed parameter no_wait please add back parameter no_wait for cmd k8s-runtime load-balancer delete
⚠️ 1001 - CmdAdd k8s-runtime bgp-peer update cmd k8s-runtime bgp-peer update added
⚠️ 1006 - ParaAdd k8s-runtime load-balancer create cmd k8s-runtime load-balancer create added parameter bgp_peers
⚠️ 1004 - CmdPropRemove k8s-runtime load-balancer disable cmd k8s-runtime load-balancer disable removed property is_preview
⚠️ 1004 - CmdPropRemove k8s-runtime load-balancer enable cmd k8s-runtime load-balancer enable removed property is_preview
⚠️ 1001 - CmdAdd k8s-runtime load-balancer update cmd k8s-runtime load-balancer update added

k8s-runtime

yonzhan avatar Apr 16 '24 06:04 yonzhan

:warning: Release Suggestions

Module: k8s-runtime

  • Update version to 1.0.0b3 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 16 '24 06:04 github-actions[bot]

❌Azure CLI Extensions Breaking Change Test

This is by-design, as the delete API changes from async to sync in stable API version.

HE-Xinyu avatar Apr 16 '24 08:04 HE-Xinyu

hi @zhoxing-ms @yanzhudd could you please review the PR? Thanks!

HE-Xinyu avatar Apr 23 '24 06:04 HE-Xinyu

hi @zhoxing-ms @yanzhudd could you please review the PR or share the status? Thanks!

HE-Xinyu avatar Apr 28 '24 07:04 HE-Xinyu

It is better to rerun some related tests in live mode to validate if the change meets your expectation.

yanzhudd avatar Apr 28 '24 09:04 yanzhudd

We did run the tests. Last comment told us to remove recording files for live tests. So how should we prove it?

ddadaal avatar Apr 29 '24 03:04 ddadaal

[Release] Update index.json for extension [ k8s-runtime ] : https://dev.azure.com/azclitools/release/_build/results?buildId=154878&view=results

azclibot avatar May 06 '24 07:05 azclibot