azure-cli-extensions
azure-cli-extensions copied to clipboard
[k8s-runtime] Make `k8s-runtime` stable
Make k8s-runtime extension stable.
- Use stable api version
2024-03-01for ARM APIs - Remove preview tags for
load-balancersandbgp-peerscommand groups
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
- [x] Have you run
azdev style <YOUR_EXT>locally? (pip install azdevrequired) - [x] Have you run
python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required) - [x] My extension version conforms to the Extension version schema
For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
❌Azure CLI Extensions Breaking Change Test
❌k8s-runtime
rule cmd_name rule_message suggest_message ❌ 1007 - ParaRemove k8s-runtime bgp-peer delete cmd k8s-runtime bgp-peer deleteremoved parameterno_waitplease add back parameter no_waitfor cmdk8s-runtime bgp-peer delete❌ 1007 - ParaRemove k8s-runtime load-balancer delete cmd k8s-runtime load-balancer deleteremoved parameterno_waitplease add back parameter no_waitfor cmdk8s-runtime load-balancer delete⚠️ 1001 - CmdAdd k8s-runtime bgp-peer update cmd k8s-runtime bgp-peer updateadded⚠️ 1006 - ParaAdd k8s-runtime load-balancer create cmd k8s-runtime load-balancer createadded parameterbgp_peers⚠️ 1004 - CmdPropRemove k8s-runtime load-balancer disable cmd k8s-runtime load-balancer disableremoved propertyis_preview⚠️ 1004 - CmdPropRemove k8s-runtime load-balancer enable cmd k8s-runtime load-balancer enableremoved propertyis_preview⚠️ 1001 - CmdAdd k8s-runtime load-balancer update cmd k8s-runtime load-balancer updateadded
k8s-runtime
:warning: Release Suggestions
Module: k8s-runtime
- Update version to
1.0.0b3in setup.py
Notes
- Stable/preview tag is inherited from last release. If needed, please add
stable/previewlabel to modify it. - Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add
major/minor/patch/prelabel to adjust it. - For more info about extension versioning, please refer to Extension version schema
❌Azure CLI Extensions Breaking Change Test
This is by-design, as the delete API changes from async to sync in stable API version.
hi @zhoxing-ms @yanzhudd could you please review the PR? Thanks!
hi @zhoxing-ms @yanzhudd could you please review the PR or share the status? Thanks!
It is better to rerun some related tests in live mode to validate if the change meets your expectation.
We did run the tests. Last comment told us to remove recording files for live tests. So how should we prove it?
[Release] Update index.json for extension [ k8s-runtime ] : https://dev.azure.com/azclitools/release/_build/results?buildId=154878&view=results