[AKS] Monitoring Addon - Improve Azure Monitor Private Link Scope Onboarding for Private clusters

[ganga1980]

Related command

az aks create --resource-group rgName --name clusterName --enable-addons monitoring --azure-monitor-private-link-scope-resource-id "amplsResourceId"

az aks create --resource-group rgName --name clusterName --enable-addons monitoring --workspace-resource-id "workspaceResourceId" --azure-monitor-private-link-scope-resource-id "amplsResourceId"

az aks enable-addons -a monitoring -g rgName -n clusterName --workspace-resource-id "workspaceResourceId" --azure-monitor-private-link-scope-resource-id "amplsResourceId"

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change [Component Name 2] az command b: Add some customer-facing feature

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• [x] The PR title and description has followed the guideline in Submitting Pull Requests.

• [x] I adhere to the Command Guidelines.

• [x] I adhere to the Error Handling Guidelines.

[azure-client-tools-bot-prd[bot]]

️✔️AzureCLI-FullTest

️✔️acr

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️acs

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️advisor

️✔️latest

️✔️3.11

️✔️3.9

️✔️ams

️✔️latest

️✔️3.11

️✔️3.9

️✔️apim

️✔️latest

️✔️3.11

️✔️3.9

️✔️appconfig

️✔️latest

️✔️3.11

️✔️3.9

️✔️appservice

️✔️latest

️✔️3.11

️✔️3.9

️✔️aro

️✔️latest

️✔️3.11

️✔️3.9

️✔️backup

️✔️latest

️✔️3.11

️✔️3.9

️✔️batch

️✔️latest

️✔️3.11

️✔️3.9

️✔️batchai

️✔️latest

️✔️3.11

️✔️3.9

️✔️billing

️✔️latest

️✔️3.11

️✔️3.9

️✔️botservice

️✔️latest

️✔️3.11

️✔️3.9

️✔️cdn

️✔️latest

️✔️3.11

️✔️3.9

️✔️cloud

️✔️latest

️✔️3.11

️✔️3.9

️✔️cognitiveservices

️✔️latest

️✔️3.11

️✔️3.9

️✔️compute_recommender

️✔️latest

️✔️3.11

️✔️3.9

️✔️config

️✔️latest

️✔️3.11

️✔️3.9

️✔️configure

️✔️latest

️✔️3.11

️✔️3.9

️✔️consumption

️✔️latest

️✔️3.11

️✔️3.9

️✔️container

️✔️latest

️✔️3.11

️✔️3.9

️✔️containerapp

️✔️latest

️✔️3.11

️✔️3.9

️✔️core

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️cosmosdb

️✔️latest

️✔️3.11

️✔️3.9

️✔️databoxedge

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️dla

️✔️latest

️✔️3.11

️✔️3.9

️✔️dls

️✔️latest

️✔️3.11

️✔️3.9

️✔️dms

️✔️latest

️✔️3.11

️✔️3.9

️✔️eventgrid

️✔️latest

️✔️3.11

️✔️3.9

️✔️eventhubs

️✔️latest

️✔️3.11

️✔️3.9

️✔️feedback

️✔️latest

️✔️3.11

️✔️3.9

️✔️find

️✔️latest

️✔️3.11

️✔️3.9

️✔️hdinsight

️✔️latest

️✔️3.11

️✔️3.9

️✔️identity

️✔️latest

️✔️3.11

️✔️3.9

️✔️iot

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️keyvault

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️kusto

️✔️latest

️✔️3.11

️✔️3.9

️✔️lab

️✔️latest

️✔️3.11

️✔️3.9

️✔️managedservices

️✔️latest

️✔️3.11

️✔️3.9

️✔️maps

️✔️latest

️✔️3.11

️✔️3.9

️✔️marketplaceordering

️✔️latest

️✔️3.11

️✔️3.9

️✔️monitor

️✔️latest

️✔️3.11

️✔️3.9

️✔️mysql

️✔️latest

️✔️3.11

️✔️3.9

️✔️netappfiles

️✔️latest

️✔️3.11

️✔️3.9

️✔️network

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️policyinsights

️✔️latest

️✔️3.11

️✔️3.9

️✔️privatedns

️✔️latest

️✔️3.11

️✔️3.9

️✔️profile

️✔️latest

️✔️3.11

️✔️3.9

️✔️rdbms

️✔️latest

️✔️3.11

️✔️3.9

️✔️redis

️✔️latest

️✔️3.11

️✔️3.9

️✔️relay

️✔️latest

️✔️3.11

️✔️3.9

️✔️resource

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️role

️✔️latest

️✔️3.11

️✔️3.9

️✔️search

️✔️latest

️✔️3.11

️✔️3.9

️✔️security

️✔️latest

️✔️3.11

️✔️3.9

️✔️servicebus

️✔️latest

️✔️3.11

️✔️3.9

️✔️serviceconnector

️✔️latest

️✔️3.11

️✔️3.9

️✔️servicefabric

️✔️latest

️✔️3.11

️✔️3.9

️✔️signalr

️✔️latest

️✔️3.11

️✔️3.9

️✔️sql

️✔️latest

️✔️3.11

️✔️3.9

️✔️sqlvm

️✔️latest

️✔️3.11

️✔️3.9

️✔️storage

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️synapse

️✔️latest

️✔️3.11

️✔️3.9

️✔️telemetry

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️util

️✔️latest

️✔️3.11

️✔️3.9

️✔️vm

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

[azure-client-tools-bot-prd[bot]]

Hi @ganga1980, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

[azure-client-tools-bot-prd[bot]]

⚠️AzureCLI-BreakingChangeTest

⚠️acs

rule	cmd_name	rule_message	suggest_message
⚠️ 1006 - ParaAdd	aks create	cmd aks create added parameter ampls_resource_id
⚠️ 1006 - ParaAdd	aks create	cmd aks create added parameter enable_high_log_scale_mode
⚠️ 1006 - ParaAdd	aks enable-addons	cmd aks enable-addons added parameter ampls_resource_id
⚠️ 1006 - ParaAdd	aks enable-addons	cmd aks enable-addons added parameter enable_high_log_scale_mode

[yonzhan]

AKS

[FumingZhang]

Could you please add a live test case for the new option?

[ganga1980]

Hi, @zhoxing-ms , @FumingZhang , can you please review this PR and also help on merging this PR?

[FumingZhang]

Could you please add a live test case for the new option?

@ganga1980, will you add a live test case?

[ganga1980]

Could you please add a live test case for the new option?

@ganga1980, will you add a live test case?

@FumingZhang , added live test to cover this new option.

[ganga1980]

Queued live test to validate the change.

• test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls

Requeued new one

@FumingZhang , I fixed the test failure, can you please re-queue this test?

[FumingZhang]

if (bool(re.match(r'/subscriptions/./resourcegroups/./providers/microsoft.insights/privateLinkscopes/.*', resource_id))) is False:

      raise InvalidArgumentValueError("--azure-monitor-private-link-scope-resource-id  not in the correct format. It should match `/subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/providers/microsoft.insights/privateLinkscopes/<resourceName>`")

E azure.cli.core.azclierror.InvalidArgumentValueError: --azure-monitor-private-link-scope-resource-id not in the correct format. It should match /subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/providers/microsoft.insights/privateLinkscopes/<resourceName>

[ganga1980]

if (bool(re.match(r'/subscriptions/./resourcegroups/./providers/microsoft.insights/privateLinkscopes/.*', resource_id))) is False:

      raise InvalidArgumentValueError("--azure-monitor-private-link-scope-resource-id  not in the correct format. It should match `/subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/providers/microsoft.insights/privateLinkscopes/<resourceName>`")

E azure.cli.core.azclierror.InvalidArgumentValueError: --azure-monitor-private-link-scope-resource-id not in the correct format. It should match /subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/providers/microsoft.insights/privateLinkscopes/<resourceName>

@FumingZhang , its my bad. I see my latest commit and didnt pushed. I pushed the fix now, can you please trigger the live test now and see if this test gets passed?

[FumingZhang]

Latest live test on case test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls

[FumingZhang]

Yet another live test

[FumingZhang]

another live test

[zhoxing-ms]

@ganga1980 Any update? Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 05-21)

[ganga1980]

@zhoxing-ms , can you please help on reviewing this PR, and triggering live test and would like to get this change in May release?

[ganga1980]

Hi, @FumingZhang , @yonzhan , can one of you please help on reviewing this PR?

[yanzhudd]

Since there are multiple changes in this PR, please list them respectively with corresponding commands in the History Notes section. e.g., [AKS] az aks create: Add --azure-monitor-private-link-scope-resource-id optional parameter ...

[ganga1980]

Since there are multiple changes in this PR, please list them respectively with corresponding commands in the History Notes section. e.g., [AKS] az aks create: Add --azure-monitor-private-link-scope-resource-id optional parameter ...

done.

[yonzhan]

Please fix CI issues