YAMAMOTO Takashi
YAMAMOTO Takashi
> If embedded platforms' compilers are compatible with C23. i suspect we can't assume they are at this point.
embedded targets sometimes require vendor-provided toolchain, which might be based on older gcc.
> I prefer not using C23 and only addressing this problem when encountering GCC 15 or higher. sure. it means not using {}, right? what do we recommend to use...
> IIUC, this problem only occurs when using GCC 15 or higher. Currently, WAMR's major development and CI environment is still Ubuntu 22.04, and its default GCC version is GCC...
> Please check whether this observation is correct. i think you are correct. also, strtok should not be used in the library as it isn't thread-safe.
> So maybe it's a good idea to replace `strtok` with `strtok_r`? it's a possible solution, yes.
> Tested native-stack-overflow on my machine on commit `a6a9f1f45d9f7ebf044ceac71bcf7a9ea2f90f23`. Without sanitizers it does not work > > ``` > ./run.sh > ====== Interpreter test1 > stack size | fail? |...
> Is this good to merge? The test failures look like timeouts; one error is "fatal error: error writing to /tmp/cckAF38s.s: No space left on device" which doesn't seem relevant....
> @yamt @TianlongLiang @loganek What are your thoughts on upgrading LLVM to version 21? i don't have strong opinions either ways. it's a bit sad to use different versions for...
* have you considered to exclude these functions from asan as suggested in https://github.com/bytecodealliance/wasm-micro-runtime/issues/4638#issuecomment-3326131777? i feel it's a better approach if it's possible. * wasm_runtime_detect_native_stack_overflow_size has a similar logic. i...