YAMAMOTO Takashi
YAMAMOTO Takashi
> maybe changes in how the libraries are built? i think the recent migration to cmake effectively added `-g`. i guess you can strip your binaries.
> iiuc, here we can replace the hash map approach with WAMR's native module instance context system, following the same pattern used by wasi itself. i agree. to take the...
> > > iiuc, here we can replace the hash map approach with WAMR's native module instance context system, following the same pattern used by wasi itself. > > >...
fixed by https://github.com/bytecodealliance/wasm-micro-runtime/pull/4396
> can take safety feature from Wasm in future (support boundary checks). how?
> > > can take safety feature from Wasm in future (support boundary checks). > > > > > > how? > > Just as WAMR's builtin libc does, do...
> let's remove from iwasm? > > #if WASM_CONFIGURABLE_BOUNDS_CHECKS != 0 > printf(" --disable-bounds-checks Disable bounds checks for memory accesses\n"); > #endif i tend to object as it would make...
> keep the flag but remove the CLI option. Let recompilation is the only way. ? i understand your suggestion. but i don't agree because iwasm is a (well, the...
my suggestion: ```c #if WASM_ENABLE_INSECURE_FEATURES == 0 #if WASM_CONFIGURABLE_BOUNDS_CHECKS != 0 #error WASM_CONFIGURABLE_BOUNDS_CHECKS is insecure. #endif #endif ```
https://github.com/bytecodealliance/wasm-micro-runtime/pull/4390 fixed this for wasi_ephemeral_nn. the legacy abi was left intact for now.