YAMAMOTO Takashi

Results 652 comments of YAMAMOTO Takashi

honestly speaking, i feel this is too much complexity for little or no benefits.

as it's to detect programming errors, it's more appropriate to use assertions. ```c bh_assert(module_inst != NULL); ```

> > as it's to detect programming errors, it's more appropriate to use assertions. > > I think the new checked version also needs to return gracefully instead of aborting...

> In my mind, these are the differences between "caller guarantee" and "callee guarantee." In a caller guarantee, the caller should always check parameters before calling. In a callee guarantee,...

if an application is passing us NULL where it shouldn't, the application is broken and it will likely crash sooner or later anyway. IMO, the only thing we can do...

> > This would end up having repercussions on wasi-sdk's implementation of vfprintf, which doesn't register line breaks properly if the file it's writing to (stdout in the case of...

restarting [SGX 143](https://github.com/bytecodealliance/wasm-micro-runtime/issues/4363) https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/15771043456/job/44455986874?pr=4395

my suggestions: * stop converting wasm NULL to native NULL. (and vice versa) [an example of the code to be fixed](https://github.com/bytecodealliance/wasm-micro-runtime/blob/9f8a6ab2d617cf6c3cb19d47b01475a929752136/core/iwasm/common/wasm_memory.c#L1394-L1396) * make wasm_runtime_validate_app_addr etc return false for native NULL....

> I think if this were true, we do need to add -fzero-init-padding-bits=unions for newer versions of GCC. as mentioned in the referenced discussion, it isn't only gcc. clang didn't...

> I will check the union {} initializer. I think we can replace them if there are not too many is it ok for us to require c23?