some features are inherently insecure

[yamt]

some of our features are inherently insecure.

for example,

• WAMR_CONFIGURABLE_BOUNDS_CHECKS
• wasi-nn load-by-name with the current design (https://github.com/bytecodealliance/wasm-micro-runtime/issues/4331)

at least they should be marked as insecure boldly to prevent users from using them casually.

[lum1n0us]

let's remove from iwasm?

#if WASM_CONFIGURABLE_BOUNDS_CHECKS != 0
    printf("  --disable-bounds-checks  Disable bounds checks for memory accesses\n");
#endif

[yamt]

let's remove from iwasm?

#if WASM_CONFIGURABLE_BOUNDS_CHECKS != 0 printf(" --disable-bounds-checks Disable bounds checks for memory accesses\n"); #endif

i tend to object as it would make testing even more difficult.

[lum1n0us]

keep the flag but remove the CLI option. Let recompilation is the only way. ?

[yamt]

keep the flag but remove the CLI option. Let recompilation is the only way. ?

i understand your suggestion. but i don't agree because iwasm is a (well, the only) convenient way to test it.

[yamt]

my suggestion:

#if WASM_ENABLE_INSECURE_FEATURES == 0
#if WASM_CONFIGURABLE_BOUNDS_CHECKS != 0
#error WASM_CONFIGURABLE_BOUNDS_CHECKS is insecure.
#endif
#endif

[lum1n0us]

Love the idea of WASM_ENABLE_INSECURE_FEATURES.