Yamen Sader
Yamen Sader
All, I had this issue for a long time as well, and the suggestion to just use -sname instead of -name is not enough for everyone. I solved it by...
+1 on this
Is merging this PR waiting on anything? I currently need this fix in my work.
Background on this is here: https://docs.google.com/document/d/17-FlYTIcLiciWdjXaQEdUnEJFbvIeIEYW3fdcEQu8ds/edit Currently a brute force approach of using 1% is done when creating the wrapped SOL account in cases where quote token == SOL: https://github.com/project-serum/serum-ts/blob/5f7ceafb1e99e542a74e4377cde1ffcf5a999e1c/packages/serum/src/market.ts#L672...
This also makes the transaction read only... if it's changed the signature is no longer valid
An implication of that is that you don't need to accurately regenerate the serialised version - it must already exist
Hmmm really good point. I guess this should really be for nonce transactions. Damn. On Tue, 25 Oct 2022 at 11:22, Joseph ***@***.***> wrote: > just thinking the partial-signed transaction...