bettercallsol icon indicating copy to clipboard operation
bettercallsol copied to clipboard

Support partially-signed trasnactions

Open sohrab- opened this issue 3 years ago • 4 comments

  • Save/export partially-signed transactions
  • Load and sign existing partially-signed transactions

For this to work, should be able to:

  • Import a partially-signed transaction buffer
  • Include existing signatures during the transaction send
  • Export data model to store signatures
    • Need to make sure our mappings are precise, otherwise the signature becomes invalid

sohrab- avatar Oct 24 '22 23:10 sohrab-

This also makes the transaction read only... if it's changed the signature is no longer valid

yamen avatar Oct 24 '22 23:10 yamen

An implication of that is that you don't need to accurately regenerate the serialised version - it must already exist

yamen avatar Oct 24 '22 23:10 yamen

just thinking the partial-signed transaction will expire in 150 blocks (approximately 1 min after it is generated), should there be something to indicate the user the expiry time of the transaction? This is so the user is not surprised when transaction expires if they read the instructions too long.

josephlabeleven avatar Oct 25 '22 00:10 josephlabeleven

Hmmm really good point. I guess this should really be for nonce transactions. Damn.

On Tue, 25 Oct 2022 at 11:22, Joseph @.***> wrote:

just thinking the partial-signed transaction will expire in 150 blocks (approximately 1 min after it is generated), should there be something to indicate the user the expiry time of the transaction? This is so the user is not surprised when transaction expires if they read the instructions too long.

— Reply to this email directly, view it on GitHub https://github.com/labeleven-dev/bettercallsol/issues/92#issuecomment-1289810131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVTZ32ILJGQUSXUKRJOUDWE4R43ANCNFSM6AAAAAARNORAUE . You are receiving this because you commented.Message ID: @.***>

-- Sent from Gmail Mobile

yamen avatar Oct 25 '22 00:10 yamen