Davy Duperron

Results 24 comments of Davy Duperron

Sorry for the late reply... missed this notification... anyway, yes this is a bug indeed and it should definitely handle that by default :+1: .

Hi @jameschenjav and thanks for the positive feedback! Basically `jql` keeps the insertion order because the `preserve_order` feature flag was introduced to avoid the default behavior of `serde_json` (https://github.com/yamafaktory/jql/pull/23, https://github.com/yamafaktory/jql/blob/main/Cargo.toml#L41)....

A follow-up on this topic. The current issue is that, as already mentioned, `serde_json` uses a flag to either internally process the data as a `BTreeMap` or an `IndexMap` (https://github.com/serde-rs/json/blob/master/src/map.rs#L30-L33)....

@kmaasrud I thought about that too but that would mean two different versions since this is a binary (this can works fine for a the library part of course). Folks...

That's an option indeed. My main concern is that it feels a bit awkward and might be even more weird regarding the packages distributed on different OS (not maintained here).

Let's maybe keep this open for a bit longer and see if some trick might help fixing that.

@akinsho thanks for the swift reply! No worries at all. I haven't checked the source code and I'm pretty new to Lua and its ecosystem. I'll try to find some...

For the record, I was facing the same issue with Marker / MarkerCluster. Not only switching to the functional version of those is needed - `MarkerF` and `MarkerClusterF` - but...

@jonathanknowles Thank you for your feedback! I was going to tell you to eventually open an issue on the stack tracker and I noticed you already did it here https://github.com/commercialhaskell/stack/issues/2642....