Yair Morgenstern

This should all be done with uniques. AI priority for policies should be independent of the type of policy, and that can certainly be modified by personality

I'm saying that "policy type" doesn't help us at all, and is unnecessary, and if we want special treatment it should be behind a unique What's really needed is AI...

So what? Policy branches also have uniques, same thing We need to think in terms of *what functionality* things have, not in terms of *what game is this similar to*...

3 sounds like "[-1 Gold]" unique on policy 4 sounds like "only available when" 2 sounds like a generally useful unique, "[relativeAmount] weight for AI, modified by [personality] personality" -...

After-the-uniques math would mean changing every usage of "foreach unique in getmatchinguniques" instead of having it be a single-place change :/

And wow, I felt my mind expand when I understood what you did with the endless sequence plus take. That's *very* clever and certainly more efficient than my solution

Current changes are good 👍🏿 Regarding potential changes: - riverTerrain would be the same for all tiles, why not have it on ruleset or tilemap? - Turning the classes into...

In DiplomacyTurnManager we do something *similar* but different - we add all the functions as extension functions to the main DiplomacyManager class

I mean, we're pretty optimized, but we're not bytecode level optimized... YET 😈

You're both better UI-ers than I am, so if you both agree on a direction I'll go with it Not sure if you want me to merge this 🤔