Yair Morgenstern comments

Results 304 comments of


                                            Yair Morgenstern

Countable scopes approach decision

Approach 3 is right out - how do we know to "link" those specific modifiers and not others? Approach 1 is good, but I don't like that we need to...

Unit Grouping

I'm willing to reopen but I can't say that I;m particularly invested in this

Feature request: UiElementDocsWriter regex issue improvement

We will judge PRs by content, not creator, add we always have. If you submit a PR that you claim was delivered to you in a dream by our good...

Honor policy's adjacency bonus should only be calculated for the unit's future position right before the attack call, not the current position

Please attach save file

Mods broken since 4.11.12

I could not replicate this either We could make these failures copy the stack trace to clipboard for debugging... would be interesting to see

Atlas and game.png file generation should make exceptions accessible to a Modder

That's some mindbending stuff

Allow access to the Dev Console on mobile devices

English throughout

Update Simplified_Chinese.properties

com.unciv.logic.TranslationTests > allTranslationsHaveCorrectPlaceholders STANDARD_OUT Placeholder `[policy]` not found in `Simplified_Chinese` for entry `Remove [policy]`

Spy Icon disabled when not on turn

@SomeTroglodyte is there anything here that's a no-go, or are these meant to be comments and hints?

com.unciv.logic.TranslationTests > allTranslationsHaveNoExtraPlaceholders STANDARD_OUT Extra placeholder `[cityStateName]` in `Italian` for entry `Your spy [spyName] successfully staged a coup in [cityName]!`