Yair Morgenstern

Results 448 comments of Yair Morgenstern

Yeah, I can't see how this would even be possible This is an internal LibGDX object that creates its child, tries to set its child's parent to itself, and then...

Since this looks to be a big change, before and after pictures are required for us to understand the possible changes

A. If all those functions are logic for the button, then we should probably have a PurchaseConstructionButton that holds all of this logic. If we had that to begin with...

I like the icons shown on the queue, I wonder what that looks like if you have a queue of ten items? I *dislike* the up and down buttons not...

Automated units are supposed to have only "automated true" set, not the action - this is so that automated units can have a state, like "set up", "fortified", etc, without...

ConnectRoad is a *specific action* we ask the unit to do. You could consider that automation or not, that's semantics. What the unit is not, is Automated, with a capital...

Merged branches are auto-deleted

This is looking kind of...verbose, let's separate this into "what you need to do" which is: - tag PRs for translation - comment in PR - merge resultant version update...

My comment still stands, "What should I do" should be minimal, and "what actually happens" can be verbose

I think enableDynamicAgentLoading is good enough. Unless there's a good reason to prefer an alternative?