Robert Forkel
Robert Forkel
Yeah, after writing this comment, it occurred to me that the paper would be the place to describe this. But I still think it would be good to have this...
The implementation is there, but the data is not yet divided appropriately.
This sounds like the perfect use case for the new data layout: A dataset which doesn't add societies, but new variables and data for another dataset's societies; but we need...
`societies_tdwg.json` is only used to populate the [`region` attribute](https://github.com/clld/dplace2/blob/11a96e510d264cf372b2370001ca90c50c25cea5/dplace2/scripts/initializedb.py#L122) - so the issue shouldn't have any effect on the app (or most analyses). The file will be regenerated when [`dplace...
I'll leave the issue open until I run `dplace tdwg` (to confirm that I was correct above :) ).
@kirbykat yes, you are right, there's potential for confusion. I think I didn't re-run the region identification, because there were no new societies (between 2.0 and 2.1). @SimonGreenhill and I...
That's mostly how it is now - we should just delete the `soc_id` and `xd_id` columns in `taxa.csv`. Right now, these two columns are more of a "checksum". The overall...
Ok, will do that. I think the reason for having `soc_id` (and `xd_id`) in `taxa.csv` was that one could imagine having phylogenies with a taxon that we know maps to...
Oh and there is an actual benefit of having `soc_id` in `taxa.csv` for checks: It makes it possible to detect cases where a glottocode may only have been changed in...
If you could batch these changes into one PR, that would be cool.