Riccardo Magliocchetti
Riccardo Magliocchetti
Uhm, if we are going to add the ability to remove a cron at runtime i think it would be make sense to let people list all the registered cron...
The preference is to do backports of changes already merged in master
If it's a sphinx-rtd-theme issue i don't how we can help unless you figure out if we can change something to make it work.
@avilaton Sorry but i'm not understanding you. What I've understood is that you have changed conf.py to use a different theme and the rendered html broke somehow. If that's not...
Could you please add a test? Also #2392 looks a different solution of the same issue, like they choose to always pass an exception
This appear to work here: ``` diff --git a/instrumentation/opentelemetry-instrumentation-grpc/tests/test_aio_server_interceptor.py b/instrumentation/opentelemetry-instrumentation-grpc/tests/test_aio_server_interceptor.py index 7b31b085..06a919c4 100644 --- a/instrumentation/opentelemetry-instrumentation-grpc/tests/test_aio_server_interceptor.py +++ b/instrumentation/opentelemetry-instrumentation-grpc/tests/test_aio_server_interceptor.py @@ -39,10 +39,8 @@ from opentelemetry.instrumentation.grpc import ( GrpcAioInstrumentorServer, aio_server_interceptor, ) -from opentelemetry.sdk...
> > The sdk is used directly in tests, should this be documented in the pyproject.toml? > > Not really, the test dependencies are defined in the `test-requirements-x.txt` files, the...
> @xrmx I think since [`NonRecordingSpan` extends](https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-api/src/opentelemetry/trace/span.py#L513) the API Span, this change would always pass. I could ofc make it verify the span context is not empty/invalid. > > That...
There's also systems-metrics: ``` instrumentation/opentelemetry-instrumentation-system-metrics/pyproject.toml: "opentelemetry-sdk ~= 1.11", ```
@ratmore Thanks for the PR, could you please elaborate a bit on why the change is needed?