Riccardo Magliocchetti

Results 409 comments of Riccardo Magliocchetti

Modified the original poster message to include the import

@robin-mader-bis It has been suggested to me to set the pools to non-blocking only at shutdown. That could be something like the following untested patch. ``` diff --git a/elasticapm/transport/http.py b/elasticapm/transport/http.py...

Ok, spent some time on this today, the previous snippet will not work because the urllib3 connection pool weakref.finalize callback will be called before our atexit callback and so the...

@robin-mader-bis would be great if you can take a look at #2085

Thanks for the PR. We should probably add some mypy run in CI to check we are not messing up anything.

> Hello, I've checked mypy output and there is a lot of errors because most of the code either does not have typing or has wrong/incomplete typing Right, maybe we...

Will converting `NaN`s to `null` fix things for you? We can fix that shortly if that's sufficient.

With apm agent 6.22.0 you can change the behaviour by installing `simplejson` as dependency and the setting the following environment variable: ``` ELASTIC_APM_TRANSPORT_JSON_SERIALIZER=elasticapm.utils.simplejson_encoder.dumps ```

The is a draft PR reworking the labeler workflow that is adding correct permissions too https://github.com/elastic/apm-agent-python/pull/2003