opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Updated SQLAlchemy required version to SQLAlchemy==1.3.0

Open ratmore opened this issue 1 year ago • 8 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [ ] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [ ] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

ratmore avatar Apr 26 '24 18:04 ratmore

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: ratmore (02ff9e068c855bbbb9638ac8126c552cd18dcaf1)

/easycla

brianwarner avatar Apr 26 '24 19:04 brianwarner

/easycla

brianwarner avatar Apr 26 '24 19:04 brianwarner

@ratmore Thanks for the PR, could you please elaborate a bit on why the change is needed?

xrmx avatar Apr 29 '24 08:04 xrmx

@ratmore Thanks for the PR, could you please elaborate a bit on why the change is needed?

This is helpful to avoid the vulnerability issues

ratmore avatar May 06 '24 15:05 ratmore

Closes #2400

brianwarner avatar Jun 05 '24 22:06 brianwarner

@shalevr Please can you help with approval

ratmore avatar Jun 06 '24 13:06 ratmore

This is helpful to avoid the vulnerability issues

Which vulnerability exactly ? This file is only used for testing (for testing the minimum supported SQLAlchemy version).

If you're using a vulnerability scanner, just update it to not report test-requirements*.txt

awoimbee avatar Jul 17 '24 10:07 awoimbee