Riccardo Magliocchetti

Results 120 comments of Riccardo Magliocchetti

You may want to use [curlylint](https://github.com/thibaudcolas/curlylint) instead of jinjalint

1) I guess they'll be allowed only since the next specification release see https://github.com/open-telemetry/opentelemetry-specification/commit/a0aee78e704d30e3cb2ce34823c347e521741e94 . Said that if a string is expected maybe it would be better to cast it...

Does something like this work for you? ``` diff --git a/opentelemetry-api/src/opentelemetry/trace/__init__.py b/opentelemetry-api/src/opentelemetry/trace/__init__.py index 9f9abe0f..e9ee0cae 100644 --- a/opentelemetry-api/src/opentelemetry/trace/__init__.py +++ b/opentelemetry-api/src/opentelemetry/trace/__init__.py @@ -527,7 +527,10 @@ def set_tracer_provider(tracer_provider: TracerProvider) -> None: _set_tracer_provider(tracer_provider, log=True)...

Not running all tests but with python 3.12.2 and wrapt 1.16.0 quite a bit of them pass: `876 passed, 62 skipped`

It should be something like `wrapt>=1.14.1,!=1.15.0` and `install_requires` in `setup.cfg` should be bumped too.

> @xrmx > > > Is there a reason comments are added after and not before the variables? > > it seems to be the pattern, e.g. here > >...

I've opened a PR on dal to make widget rendering a bit more robust to handle this case https://github.com/yourlabs/django-autocomplete-light/pull/860

Also this https://github.com/shamanu4/dal_admin_filters/pull/12 will make setting the id a lot easier

What I mean is that it would be cool to reuse, if possible, the hook at master.c:643 https://github.com/unbit/uwsgi/pull/1995/files#diff-d752b2bf332e435717f74037eb981f1fL642 instead of adding the master_start callback in the uwsgi_plugin struct.

@nickwilliams-eventbrite AFAIK there's no interface for internal callers to use the hook system. Maybe @unbit can chime in to sort out if it's a good idea or not?