Robert Kaussow

Results 262 comments of Robert Kaussow

Have only seen it in rare cases, so need to check if I can find an affected repo.

Still see this issue: ``` {"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-d0e4a176f1"} ```

Yes it would. We can still decide to introduce another config option but as said in the issue the current behavior doesnt make sense to me.

What's the best way to make it none-breaking? What I tried is to add a flag `WOODPECKER_FILTER_LABELS_REQUIRED=true/false` but how to pass it to the `grpc.Next` method? I think the attribute...

I thought about it again and to might be helpful for some use cases to keep the current behavior but make it configurable. @anbraten can you guide me a bit...

Sure we could, I still think this should be better configurable but open for other decisions.

That is correct, and I don't think we should allow adding user-defined ones. Maybe you can explain your use-case a bit more. In general, Ansible roles and collections should be...

Implementing https://github.com/thegeeklab/ansible-doctor/issues/763 might help as well, but also doesn't allow arbitrary fields.

I'm fine to implement a `required` annotation subtype for vars as I think it makes sense, but Im against adding an option for user configured subtypes.

It gets even worse. Even if the pipeline status is correct in the UI, `CI_PIPELINE_STATUS` is wrong, which makes it pretty useless to use for notifications :see_no_evil: ![image](https://github.com/woodpecker-ci/woodpecker/assets/3391958/2303f4fe-c2b3-4f2d-a701-482c4464bb1e) while `CI_PIPELINE_STATUS`...