Robert Kaussow
Robert Kaussow
Thanks for the details! But shouldn't we not just fix the IMO broken and useless behavior of `WOODPECKER_FILTER_LABELS`? While your approach might work, it sounds a bit like a workaround,...
Looks like this was already fixed upstream but not yet released, https://github.com/helm/chart-releaser/pull/486. Missed that last time I looked into the upgrade.
Fixed by https://github.com/woodpecker-ci/helm/pull/330
@woodpecker-ci/maintainers I would like to work on `improve error handling for missing args (missing repo id / name results in an parseInt error atm)` How do we want to handle...
Obviously, but I could also name a lot of tools without args. We could have a way more clean code without arg validation, as flag validation and required flags is...
There is no required args feature, just a required flags option.
Can we please start adding tests for new code?
Same here, we just use `repo, err := git.PlainOpen(".")` (see https://github.com/thegeeklab/git-sv/blob/main/app/app.go#L160) and get `failed to push tag: ssh: handshake failed: knownhosts: key mismatch` on pushing a tag to the repo...
> I've brushed this issue, so I may be completely off the mark, but migrating from `go-git/v5` to `go-git/v6` fixed the problem for me — in case it helps someone...
@pjbgf what's the current state? Any chance to get this issue fixed? Anything missing, we can provide to help?