Anton Zinovyev

Results 204 comments of Anton Zinovyev

@timc13 package names, as it is working right now. There is o sense in pathname matching, since all you care is package and type name

Call sites can and should be managed on golangci-lint side.

This is out of scope of this linter🤔 And besides - we're using it sometimes..

Similarly (but having react 18), having a `for` loop in the body of a functional component, even if it is unrelated to hooks, causes the linter to report that all...

@felix-roehrich, you are correct. There should be a return statement instead of break -- I've had a feeling that something is off regarding iteration stop, but, as said, not much...

Or, actually, not.. If i dont miss anything -- there is no reason for user of iterator to check `rows.Err()` in any case. - In case everything wen good --...

You didn't mention him BTW, there is space between "at" and nickname🤭 Regarding the name, GO [proposes ](https://pkg.go.dev/iter#hdr-Naming_Conventions) the name `All` for functions that returns iterator over all entries of...

I personally don't understand how to use `ForEachRow` to scan rows into structures of.. say 20 fields, without introducing templating engine and codegeneration (which sound odd to me by definition)....

Aaah.. Actually i have implemented similar function for our internal lib at the moment `pgx` gained generic scanners🤭 ```go func ForScannedRows[T any](rows pgx.Rows, scanner pgx.RowToFunc[T], fn ScannedRowIteratorFn[T]) error { defer...