Anton Zinovyev
Anton Zinovyev
@ArttuOll i just rememebered why we still not using react 18 and its hooks =) the teting library do not support react 18, the solution they offer is switching to...
So, you've - added new dependency (not compatible with our testing pipeline - globally disabled linting rule without any reasoning - once again ignored PR guidelines Last one is somehow...
@develohpanda ill update eslint config it couple of days - should help
ill review it sometime this week
On review - no, tests - failing =)
youi also have to add the hook to radme. otherwise - looks good
also linting is failing
You can see linting annotations within files tab of pull request. Linter should be run with `yarn lint` command
you should also add tests for pausing resuming, etc. you should target 100% coverage and in this case is it easily achievable.
It is somehow achievable without true multipass - i've been planning to review this\next week when ill have some free time.