Mete Fatih Cırıt
Mete Fatih Cırıt
I didn't take [--packages-above](https://colcon.readthedocs.io/en/released/reference/package-selection-arguments.html#package-selection-arguments) into consideration. > --packages-above [PKG_NAME [PKG_NAME …]] > Select the packages with the passed names as well as packages which recursively depend on them. So we...
Related: https://github.com/orgs/autowarefoundation/discussions/3469#discussioncomment-5965946
@esteve let's consider following scenario: ```mermaid graph TD F:::cls_01 -->|"depends on"| D:::cls_03 D -->|"depends on"| E:::cls_02 D -->|"depends on"| C:::cls_04 C-->|"depends on"| B:::cls_05 B -->|"depends on"| A:::cls_06 classDef cls_00 fill:#DDDDDD,stroke:#999,stroke-width:1px;...
@kminoda one way is to store the build artifacts with the commit hash of the universe repository. Then we can check if they match. (In the beginning of the `build-and-test-differential`...
Will be hopefully solved by: - https://github.com/autowarefoundation/autoware/issues/3999
Now that - https://github.com/autowarefoundation/autoware/issues/3999 is completed, we can close this. ✨🎇
@ambroise-arm thanks for reminding this, It's been so long, I forgot the real premise of my proposal 😅 To recap: - Our docker images were too big for public runners...
> ```bash > $ colcon list --packages-up-to C > A, B, C > > $ colcon list --packages-above C > C, D, F > > $ colcon list --packages-above-depth 1...
We would need to restructure colcon-build action from [autoware-github-actions](https://github.com/autowarefoundation/autoware-github-actions/tree/main) and sync it with [autoware.universe repo](https://github.com/autowarefoundation/autoware.universe/blob/main/.github/workflows/build-and-test-differential.yaml). - https://github.com/autowarefoundation/autoware-github-actions/blob/8ce979ef277058cd28af34ebecf35347e658b576/colcon-build/action.yaml#L53-L85 Currently this is too much work for relatively little benefit (compared to the...
> EDIT: Oh, was "from most recent successful previous run" the important part? Yeah, that might be a problem. Exactly, this requires a good orchestration effort. Uploading most recent successful...