Ondrej Medek
Ondrej Medek
I like the idea from https://github.com/bhearsum/redo to have `retrying` contextmanager: ```python from tenacity import retry from tenacity.stop import stop_after_attempt @contextmanager def retrying(func, *retry_args, **retry_kwargs): yield retry(*retry_args, **retry_kwargs)(func) def foo(max_count): global...
Following discussion in #234 I propose a very simple customizable (error) logging. Instead of hard coding `console.error(err)`, define the global logging API with the default implementation, e.g. ```js const dstoreLog...
`getPersistedLevel` is called for each logger. I do not need that. I think the persistence should be configurable same way as `methodFactory` for plugins - i.e. it should be possible...
I want to crate a `TcpConnectionListener` to bind to the first free port. It works fine, however, I cannot get the port number: ```c# listener = new TcpConnectionListener(new NetworkEndPoint(IPAddress.Loopback, 0));...
As a defensive programmer 😃 I would welcome a switch to allow to use defined events only. Something like: ```js var emitter = new EventEmitter(); emitter.defineEvents(["my-event-1", "my-event-2"]); emitter.setValidating(true); // switch...
When using IL2CPP compiler (AOT - Ahead Of Time), then `JSON.ToObject` fails with: `System.NotSupportedException: System.Reflection.Emit.DynamicMethod::.ctor`. This is a problem for platforms like Unity3D, Xamarin and others, see #46, #49, #60...
Do not throw general `Exception`. Make a custom `JsonException` class and throw it instead. So, it's possible to catch this specific exception (higher in the code).
The `FitFile.protocol_version, profile_version` are just strings "major.minor" (i.e. "int dot int" format), not floats. Floats are inaccurate representations. I propose to create a custom class `FitVersion` with fields `major, minor`...
Fix #8 I have started with `FitFileEncoder`, see the `test_encoder.py`. I will rebase this PR while fixing the `FitFileEncoder` and edit this initial message. The messages are created by `DataMessageCreator`...
Fix #55 The second commit limits the data processor `getattr`.