python-fitparse icon indicating copy to clipboard operation
python-fitparse copied to clipboard

Published 20 hours ago • verified publisher icon dtcooper

Protocol and profile versions are not float

Open xmedeko opened this issue 6 years ago • 1 comments

The FitFile.protocol_version, profile_version are just strings "major.minor" (i.e. "int dot int" format), not floats. Floats are inaccurate representations. I propose to create a custom class FitVersion with fields major, minor and __str__ func with proper formatting. And maybe magic functions for comparison (__eq__, __gt__, ...). Can make a PR for that.

xmedeko avatar Mar 07 '18 08:03 xmedeko

PR to address this here: https://github.com/dtcooper/python-fitparse/pull/135

fundthmcalculus avatar Nov 01 '21 16:11 fundthmcalculus