Xun Jiang comments

Results 44 comments of


                                            Xun Jiang

Have only one method to set default values

There is no `set_up_trajectory_params` in Aviary.

Have only one method to set default values

> need to double check if this issue is resolved It is probably resolved because there is no `set_up_trajectory_params` in Aviary now.

Remove input_variables.py

There is no `input_variables.py` in the current Aviary source code.

Unify mission range and distance variable names

There is no `Dynamic.Mission.RANGE` but `Dynamic.Mission.DISTANCE`. So, it is likely that it is done already. BTW, there is `Mission.Landing.GROUND_DISTANCE`. So, `ground_distance` may not be the best name.

FLOPS validation input data needs to be split into inputs and options

There is no `test_flops_based_static_analysis.py` as of version 0.9.4.

Finish setting default in aerodynamic and mass subsystems

The third item `Aircraft.Engine.ADDITIONAL_MASS_FRACTION` is fixed in [https://github.com/OpenMDAO/Aviary/pull/684](https://github.com/OpenMDAO/Aviary/pull/684)

BWB components in mass/flops_based subsysterms

By now, unit testing on FLOPS based mass for simple layout and simple wing is done.

BWB components in mass/flops_based subsysterms

By now, unit testing on FLOPS based mass for detailed layout and detailed wing is done.

BWB components in mass/flops_based subsysterms

Convert `NETAW` to `Aircraft.Wing.NUM_INPUT_STATION_DIST`. We don't need it in general but need it for BWB.

Off design overhaul

In GAST, there are a few input variables related to off design. Examples: ARNGE(3) = 900., ! Off Design Altitude, Short Range ARNGE(4) = 0., ! Off Design Altitude, Long...