OpenMDAO
Finish setting default in aerodynamic and mass subsystems
Desired capability or behavior.
PR #666 sets most of variables to defaults according to meta_data. There are a few exceptions:
- In
subsystems/aerodynamics/flops_based/mux_component.py:-
Aircraft.Wing.CHARACTERISTIC_LENGTH -
Aircraft.HorizontalTail.CHARACTERISTIC_LENGTH -
Aircraft.VerticalTail.CHARACTERISTIC_LENGTH -
Aircraft.Fuselage.CHARACTERISTIC_LENGTH
-
If I set them to default values 0.0, docs/getting_started/onboarding_level3.ipynb fails.
- In
variable_info/variable_meta_data.py:-
Aircraft.Wing.FORM_FACTOR -
Aircraft.VerticalTail.FORM_FACTOR -
Aircraft.HorizontalTail.FORM_FACTOR
-
If I set their default_values to 0.0 instead of 1.25, validation_cases/benchmark_tests/test_bench_GwGm.py:test_bench_GwGm_shooting() fails.
- In
subsystems/mass/gasp_based/fixed.py:-
Aircraft.Engine.ADDITIONAL_MASS_FRACTION
-
If I set it to default value 0.0, validation_cases/benchmark_tests/test_bench_GwGm.py:test_bench_GwGm(), validation_cases/benchmark_tests/test_bench_GwGm.py:test_bench_GwGm_shooting(), validation_cases/benchmark_tests/test_off_design_GwGm.py fail. The value of aircraft:engine:additional_mass_fraction in aircraft_for_bench_GwGm.csv has not impact on the results.
We need to investigate these three cases.
Is your feature request related to a problem? Please describe.
No response
Associated Bug Report
No response
The third item Aircraft.Engine.ADDITIONAL_MASS_FRACTION is fixed in https://github.com/OpenMDAO/Aviary/pull/684