Xiaoge Su

Results 19 comments of Xiaoge Su

This is tested by 1) build FDB using clang/ldd/libc++ 2) build FDB using gcc/ld/libstdc++ in okteto enviroment. Both build succeed.

> This broke the clang build for me. I'm using the current build of dev container; default environment variables + okteto distcc stuff: > > ``` > - DISTCC_HOSTS=--randomize ......

Fixed by passing CMAKE_CXX_FLAGS to RocksDB build

The root cause of why we are not being able to forward the corresponding flags to RocksDB is that: 1. We are determining the compiler/linker flags in `ConfigureCompiler.cmake`. The`ConfigureCompiler.cmake` is...

> RocksDB is built using cmake. I would suggest to use [FetchContent](http://cmake.org/cmake/help/v3.24/module/FetchContent.html) to get the RocksDB source (I think this can be done in a way so it only is...

> I think a possible approach is to let the compiler/library configuration goes to CMAKE_CXX_FLAGS while the remaining can stay in COMPILE_OPTIONS.

Since the correctness 100k passed, we will merge without pr cluster pass.

Need to think how to test this manually.

See some correctness (5/100000) failures but unable to reproduce locally.

This is manually tested by 100k correctness run. So we skip the PR Cluster Tests which failed for reason not related to code.