Refactor ClientStatusStats and ClientStats

[xis19]

MonitorLeader.actor.cpp:ClientStatusStats and Status.actor.cpp:ClientStats shares the same structure, thus refactored.

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

• [ ] The PR has a description, explaining both the problem and the solution.
• [ ] The description mentions which forms of testing were done and the testing seems reasonable.
• [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

• [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
• [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

[xis19]

Need to think how to test this manually.

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 0e33c771bc953d375e736363b3db6ed3ae18102f
• Duration 0:04:51
• Result: :x: FAILED
• Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 0e33c771bc953d375e736363b3db6ed3ae18102f
• Duration 0:04:52
• Result: :x: FAILED
• Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
• Build Logs (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 0e33c771bc953d375e736363b3db6ed3ae18102f
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: a3e3f93194c4bd8e08c821e7c291da7764bab366
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

• Commit ID: a3e3f93194c4bd8e08c821e7c291da7764bab366
• Duration 0:43:29
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: a3e3f93194c4bd8e08c821e7c291da7764bab366
• Duration 0:56:15
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: a3e3f93194c4bd8e08c821e7c291da7764bab366
• Duration 1:42:47
• Result: :x: FAILED
• Error: Error while executing command: make -C tests test_ycsb.run. Reason: exit status 2
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

• Commit ID: 2690d0bc03c8e2b22c85526143ad47f552da8f87
• Duration 0:43:26
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: b246e943a2c743505c6c8c542b56cc76da081c90
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 2690d0bc03c8e2b22c85526143ad47f552da8f87
• Duration 1:21:32
• Result: :x: FAILED
• Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: b246e943a2c743505c6c8c542b56cc76da081c90
• Duration 1:17:52
• Result: :x: FAILED
• Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: b246e943a2c743505c6c8c542b56cc76da081c90
• Duration 1:20:10
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 2690d0bc03c8e2b22c85526143ad47f552da8f87
• Duration 1:26:39
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[xis19]

See some correctness (5/100000) failures but unable to reproduce locally.

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

• Commit ID: 74a1d2179199d63616515dda89a8862cbc18ee67
• Duration 0:44:23
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 74a1d2179199d63616515dda89a8862cbc18ee67
• Duration 1:02:39
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 74a1d2179199d63616515dda89a8862cbc18ee67
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 74a1d2179199d63616515dda89a8862cbc18ee67
• Duration 1:21:35
• Result: :x: FAILED
• Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
• Build Logs (available for 30 days)

[xis19]

This is manually tested by 100k correctness run. So we skip the PR Cluster Tests which failed for reason not related to code.