Xiang Fu
Xiang Fu
Just realized the duplicated effort https://github.com/getredash/redash/pull/5724
Adding more type support:
Also tested with auth-zk pinot quickstart: ``` docker run --name pinot-quickstart --network redash_default \ -p 9000:9000 -p 8000:8000 -d\ apachepinot/pinot:latest QuickStart \ -type AUTH-ZK ``` With Data Source
> Please let me know when you feel this is ready for review 👌 Yes, please. Logic wise it's pretty much there.
I've tried to capture the feedbacks for type mapping from #5724 and #5446
@susodapop can you start reviewing this PR, thanks!
> Thanks for the ping! I will review it this week. Kindly bump up the thread :p
Guess I forgot to @susodapop last week :p
> > Guess I forgot to @susodapop last week :p > > I appreciate you pinging me so reliably. I've been hard at work on a couple other open source...
@ebyhr can you take another pass for this