Adding Apache Pinot Query Runner

[xiangfu0]

What type of PR is this?

• [ ] Refactor
• [ ] Feature
• [ ] Bug Fix
• [X] New Query Runner (Data Source)
• [ ] New Alert Destination
• [ ] Other

Description

Adding Apache Pinot query runner.

How is this tested?

• [ ] Unit tests (pytest, jest)
• [ ] E2E Tests (Cypress)
• [X] Manually
• [ ] N/A

1. Start redash docker-compose

docker-compose up -d && docker-compose run --rm server create_db && docker-compose run --rm postgres psql -h postgres -U postgres -c "create database tests"

2. Start Pinot Quickstart

docker run \
    --name pinot-quickstart \
    --network redash_default \
    -p 9000:9000 -d \
    apachepinot/pinot:latest QuickStart \
    -type batch

This docker run create a Pinot cluster with controller at http://pinot-quickstart:9000 and broker athttp://pinot-quickstart:8000

3. Create data source:

4. Query Builder

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

[xiangfu0]

Just realized the duplicated effort https://github.com/getredash/redash/pull/5724

[susodapop]

I'm not seeing any movement on #5724 from that contributor. So I'm happy to move forward with this one assuming we can incorporate the feedback from the two previous attempts. The big question was around data type mapping, as I recall.

[xiangfu0]

Adding more type support:

[xiangfu0]

Also tested with auth-zk pinot quickstart:

docker run --name pinot-quickstart --network redash_default \
    -p 9000:9000 -p 8000:8000  -d\
    apachepinot/pinot:latest QuickStart \
    -type AUTH-ZK

With Data Source

[susodapop]

Please let me know when you feel this is ready for review 👌

[xiangfu0]

Please let me know when you feel this is ready for review 👌

Yes, please. Logic wise it's pretty much there.

[xiangfu0]

I've tried to capture the feedbacks for type mapping from #5724 and #5446

[xiangfu0]

@susodapop can you start reviewing this PR, thanks!

[susodapop]

Thanks for the ping! I will review it this week.

[xiangfu0]

Thanks for the ping! I will review it this week.

Kindly bump up the thread :p

[xiangfu0]

Guess I forgot to @susodapop last week :p

[susodapop]

Guess I forgot to @susodapop last week :p

I appreciate you pinging me so reliably. I've been hard at work on a couple other open source projects for the past month. But I swear I haven't forgotten about you :)

[xiangfu0]

Guess I forgot to @susodapop last week :p

I appreciate you pinging me so reliably. I've been hard at work on a couple other open source projects for the past month. But I swear I haven't forgotten about you :)

Thanks for your comments!

Seems the CI cannot pass due to some visual change, can you help check what's going on?

[xiangfu0]

@susodapop another round :p

[xiangfu0]

Seems like the CI passed! @susodapop can you go through this again ?

[xiangfu0]

@susodapop ping :p

[xiangfu0]

kindly Friday ping 🔢 @susodapop

[susodapop]

Thank you for the pings :) I have been out sick this week. Will review ASAP.

[xiangfu0]

Thank you for the pings :) I have been out sick this week. Will review ASAP.

Oh, hope you get well soon and take your time!

[arikfr]

Merged. Thank you for your patience with this, @xiangfu0 !

[xiangfu0]

Many thanks @arikfr and @susodapop !! Great team work!