xezon

Snow glitch is also present before that fixup commit.

New `Thyme::GameTextFile` class is capable of merging CSF and STR files comfortably. Therefore this feature can be implemented easily in the new Thyme::GameTextManager. * #499

I would say let's leave this change open for now and re-investigate as soon as more surrounding code is available. Ideally we fix it so it never crashes even if...

This is needed yes. For starters, we could build a client hash off of Game Code Hash, INI hash and W3D data hash. This can uniquely identify a Mod and...

Yes `auto` could be ok here, because the type is already written on the right side. ```c++ auto &g_waterSettings = Make_Global(PICK_ADDRESS(0x00A2F0B8, 0x00A2F0B8)); ``` Will this compile?

Audio volume also needs a look. Sounds currently do not respect volume settings from Options menu.

Snow and Rain looks good. No crashes. Tested in RelWithDebInfo.  

The "destretch" approach is a good idea too. I am copying the image here for safe-keeping  Other than that, since a few years we also have a "Control Bar...

All links updated from xezon/GeneralsGamePatch to TheSuperHackers/GeneralsGamePatch. This report is in need of an update at some point.

I have added better comments to the shadow buffer limits. Doubling `MAX_NUMBER_SLOTS` is certainly legal and achieves the desired effect. It allows for more shadows to be drawn in the...