Thyme icon indicating copy to clipboard operation
Thyme copied to clipboard

Implements SnowManager and W3DSnowManager.

Open tomsons26 opened this issue 4 years ago • 2 comments

This class handles both snow and rain.

Maps to test on are: Snow: Bitter Winter, Lights Out Rain: Winding River, Eastern Everglades, Flood Planes, Rocky Rampage

tomsons26 avatar Nov 24 '21 03:11 tomsons26

I tested this change on Bitter Winter (2) map. Looks like the snow effect is glitching a bit. Just idle and observe after spawn.

xezon avatar Feb 07 '22 18:02 xezon

Snow glitch is also present before that fixup commit.

xezon avatar Feb 08 '22 18:02 xezon

Codecov Report

Base: 3.31% // Head: 3.30% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (2b087ae) compared to base (6a96b6f). Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #381      +/-   ##
==========================================
- Coverage     3.31%   3.30%   -0.01%     
==========================================
  Files          749     750       +1     
  Lines        69787   69865      +78     
  Branches     11321   11325       +4     
==========================================
  Hits          2311    2311              
- Misses       67155   67233      +78     
  Partials       321     321              
Impacted Files Coverage Δ
src/game/client/snow.cpp 0.00% <0.00%> (ø)
src/game/weather.h 0.00% <ø> (ø)
src/platform/w3dengine/client/w3dsnow.cpp 0.00% <0.00%> (ø)
src/w3d/renderer/assetmgr.cpp 6.54% <0.00%> (-0.02%) :arrow_down:
src/w3d/renderer/dx8caps.h 0.00% <ø> (ø)
src/w3d/lib/cpudetect.cpp 21.17% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Feb 09 '23 21:02 codecov-commenter

Snow and Rain looks good. No crashes. Tested in RelWithDebInfo.

shot_20230210_230624_4

shot_20230210_230718_6

xezon avatar Feb 10 '23 22:02 xezon

Obsoleted by my new work.

jonwil avatar Sep 13 '23 21:09 jonwil