Thyme
Thyme copied to clipboard
Implements SnowManager and W3DSnowManager.
This class handles both snow and rain.
Maps to test on are: Snow: Bitter Winter, Lights Out Rain: Winding River, Eastern Everglades, Flood Planes, Rocky Rampage
I tested this change on Bitter Winter (2) map. Looks like the snow effect is glitching a bit. Just idle and observe after spawn.
Snow glitch is also present before that fixup commit.
Codecov Report
Base: 3.31% // Head: 3.30% // Decreases project coverage by -0.01% :warning:
Coverage data is based on head (
2b087ae) compared to base (6a96b6f). Patch coverage: 0.00% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@
## develop #381 +/- ##
==========================================
- Coverage 3.31% 3.30% -0.01%
==========================================
Files 749 750 +1
Lines 69787 69865 +78
Branches 11321 11325 +4
==========================================
Hits 2311 2311
- Misses 67155 67233 +78
Partials 321 321
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/game/client/snow.cpp | 0.00% <0.00%> (ø) |
|
| src/game/weather.h | 0.00% <ø> (ø) |
|
| src/platform/w3dengine/client/w3dsnow.cpp | 0.00% <0.00%> (ø) |
|
| src/w3d/renderer/assetmgr.cpp | 6.54% <0.00%> (-0.02%) |
:arrow_down: |
| src/w3d/renderer/dx8caps.h | 0.00% <ø> (ø) |
|
| src/w3d/lib/cpudetect.cpp | 21.17% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Snow and Rain looks good. No crashes. Tested in RelWithDebInfo.


Obsoleted by my new work.