xermicus comments

Results 97 comments of


                                            xermicus

Make `uint` default to `uint64` rather than `uint256`

I am not sure whether this is a good idea. As a Solidity compiler, we should stick to whatever is default in the Solidity language. I fear that by changing...

Files with \r\n can be incorrectly tokenized

@seanyoung did #745 fix this?

Files with \r\n can be incorrectly tokenized

Ok, I'm not closing this then. Thanks!

msg.sender provides wrong AccountId on substrate

This has been fixed a while ago.

Not able to deploy contract on substrate after compiling it successfully

The contract compiles and deploys fine with a recent Solang version.

Be clear on solana support

@LucasSte #1225 fixed this?

Not able to execute transferFrom function of NFT in substrate

@Sandeep-Narahari without the full source code of your contracts it's hard to debug this further. However, since there's the `address` type in the function signature, this might be related to...

Solang does not implement address.code

I'm going to pick this up, [we need it](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/cb4bf950df5ae43356c4935b3900446f6dc20261/contracts/proxy/ERC1967/ERC1967Utils.sol#L67).

Solang does not implement address.code

@bkushigian yeah good point, it certainly can be implemented in sema but not in later stages. But let's just keep this issue only, implementing it in sema is part of...

Solang does not implement address.code

@bkushigian FIY I implemented it for sema in #1549