Dusan Jakub

Results 9 comments of Dusan Jakub

fix: Stack overflow on multi maps (and other non-trivial generic classes)

TODO: wait for a new release of sundrio by @iocanel, then update version in pom.xml

fix: Stack overflow on multi maps (and other non-trivial generic classes)

Superseded by fabric8io/kubernetes-client#4501. The next release of sundrio 0.93.1 contains not only the original fix for stack overflow, but also additional work to fully support multimaps and generate correct schema...

Stack overflow on multi maps (and other non-trivial generic classes)

I forgot to mention, this only happens on 6.x version, for 5.x it does not fail

Stack overflow on multi maps (and other non-trivial generic classes)

Here's PoC fix: https://github.com/fabric8io/kubernetes-client/commit/d62cba1f842b1603409b1f915b238d0bd6480f48

Stack overflow on multi maps (and other non-trivial generic classes)

Hi @andreaTP, yes I know about substitutions the Keycloak team needed to implement to fix their model. The problem is that when they upgrade to 6.0.0, their model will not...

Stack overflow on multi maps (and other non-trivial generic classes)

There really is a bug in sundrio. It took me a while to simulate it, but I was successful in the end. Interestingly, kubernetes-client does not directly use the code...

Stack overflow on multi maps (and other non-trivial generic classes)

No, it's not fixed. The fix in sundrio only applies to their `TypeArguments` util. It is not used in `crd-generator`, I wrote that it is a duplicate of code from...

Stack overflow on multi maps (and other non-trivial generic classes)

Update: I have made a PR to sundrio, fixing the issue (sundrio/sundrio#340). I have also made a PR here, which however relies on the changed code, so it won't compile...

Stack overflow on multi maps (and other non-trivial generic classes)

ping @andreaTP, sundrio has been released and the linked PR is ready for review