DivisionByZero

Results 216 comments of DivisionByZero
trafficstars

The suggested solution you provided sounds reasonable to me. Other locales could gain value from this as well. In my opinion, we should call the property in the definition `default_full_name_order`....

> Maybe we can use parameters by country name liked this > > ```ts > import { faker } from '@faker-js/faker'; > > console.log(faker.name.fullName()); // Lexie Bernie > > console.log(faker.name.fullName({...

IDK, `crypto()` could fit into the `finance` module and `hashAlorythm()` in the `hacker` module. I don't see the need for a new module.

> I think datatype.benfordNumber or something similar might be useful. (We might later shift it - along with other methods - to a new and separate number module though). Lets...

In that case, this would replace the current meresenee twister RNG? It's just a different approach to a problem we already solved. That would be even more prove, to put...

Just to make clear. I'm not discouraging or blocking this idea. I quite like it TBH. I just want to make sure that the project architecture is respected.

Would it be possible to integrate this change as a non-breaking change? Maybe with some proxy magic and deprecation of the current classes (in the constructor)?

Concept: Add a job to the [`ci.yaml`](https://github.com/faker-js/faker/blob/508082cbde088d2834b324c15dd75f326cb896c7/.github/workflows/ci.yml) that runs the `generate-locale` and `generate-locale` scripts from our [`package.json`](https://github.com/faker-js/faker/blob/508082cbde088d2834b324c15dd75f326cb896c7/package.json#L60-L61).

If calling the method with an empty array is considered a bug, what would be the correct behavior for empty arrays?

If it could return `undefined` you must extend the method signature with `undefined` as return value. This can be very exhausting for end-users (because undefined check). So I would say...