Andrey Borodin

Results 333 comments of Andrey Borodin

Hi! Information about the count of checksum violations is added to backup sentinel. Pull request with a warning to log would be welcome. But several checksum violations may be observed...

Yeah, a short-reading page should be treated as a clear sign of corruption. That's a bug. Looking at this code I wonder: why do we read file one more time...

Errr, no. We do not want to exclude these dirs totally. We Just want to exempt them from incremental backup - they will be put into delta backups as a...

Yup, it's a bug. [Here ](https://github.com/wal-g/storages/blob/master/s3/folder.go#L194)we need to check every error of [DeleteObjectsOutput](https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/S3/Types/DeleteObjectsOutput.html) because some of objects may be deleted successfully and some not.

Hi! Sorry for the long reply. Unfortunately now this is impossible. If you send a PR I would happily review it. Here's relevant code https://github.com/wal-g/wal-g/blob/master/pkg/storages/gcs/folder.go#L291 . You can introduce new...

Thanks for reporting, @ilicmilan ! Yup, that's a bug, I've fixed it first time in 2018, sad but it regressed again. It's also known as #539 We will fix this....

I think we have PG version in metadata and can display it with --detail option. Funny that we do not have WAL-G version... BTW I suppose we can close this...

Thanks for reporting! Looks like a bug in symlink handling...

There was a related fix #1057, but not exactly this one, sorry. A PR would be welcomed.

Hi! thanks for the report! I belive this must be fixed in https://github.com/wal-g/wal-g/pull/500 not sure we had releases after fix though.