Daniel Kłobuszewski

Thanks, I like the echo statement idea. Since we're over 2 months from 1.28 k8s release, I suggest the following timeline: 1. [now] Add the echo statement. 1. [now] Send...

Ok, let's make it 3 months then. It means we may hit some incompatibilities in the vendor dir when releasing CA 1.28, but hopefully that'll be the last time. @fmuyassarov...

Thanks for following up on this!

Hi @guopeng0 Thanks for your interest in this. I think I would start from building some proof of concept and ideally discussing on the SIG meeting on Monday. Reusing the...

/assign

Apologies for slow review. LGTM now. /lgtm /approve

Since there's no linked issue, can you clarify what is the bug you're trying to fix with this change?

/lgtm /approve

Assigning since looks like this is being reviewed by you already. /assign @tallaxes @rakechill

Change itself LGTM, though WDYT about moving this code to `cluster-autoscaler/cloudprovider/azure/processors`? You wouldn't require global CA approval that way. /assign