autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

use getvmss api for spot instances in azure

Open gandhipr opened this issue 1 year ago • 9 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for using getVMSS api for instances in order to collect most recent count in the spot nodepool

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

getVMSS api will be called when using spot instances for having better updated information

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


gandhipr avatar Jan 25 '24 18:01 gandhipr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gandhipr, rakechill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 19 '24 16:03 k8s-ci-robot

/retest

jackfrancis avatar Mar 22 '24 03:03 jackfrancis

Assigning since looks like this is being reviewed by you already.

/assign @tallaxes @rakechill

x13n avatar May 07 '24 18:05 x13n

@x13n: GitHub didn't allow me to assign the following users: rakechill.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

Assigning since looks like this is being reviewed by you already.

/assign @tallaxes @rakechill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 07 '24 18:05 k8s-ci-robot

/test pull-cluster-autoscaler-e2e-azure

jackfrancis avatar May 07 '24 20:05 jackfrancis

/retest

jackfrancis avatar May 07 '24 21:05 jackfrancis