Zhentao Wang (汪臻涛)

Results 26 comments of Zhentao Wang (汪臻涛)

Hi, what is the standard folder/file to add tests here? Did you mean tests for CI purpose?

Test of the complex routine now added. Some further explanations on the changes: 1. "complex_symmetric_runner" is renamed to "complex_nonsymmetric_runner". In ARPACK there is no complex routines designed specifically for "symmetric"...

Yes, happy to. I see the file "CHANGES" starting like the follow, and should I put my changes above/below "arpack-ng - 3.9.0"? ---------- arpack-ng - 3.9.0 [ Jose E. Roman...

I have added a few more changes to the test file "icb_arpack_cpp.cpp": 1. change "ldz" to the minimal allowed value "N", "z" to the minimal allowed size "ldz * nev",...

> > Same changes in file icb_parack_c.c added. > > You meant `icb_arpack_c.c`? `icb_parpack_c.c` is unchanged. You are right -- I meant "icb_arpack_c.c" not the parpack file. For the initialization...

> Can you do the same kind of clean-up for `parpack.hpp`, `icb_parpack_c.c`, `icb_parpack_cpp.cpp`? Thanks! > > > What do you think? If you want, I can still switch on ipram[4]...

@fghoussen Hi, previously I disabled MPI so the check works. Now, with MPI enabled to work on parpack, I am hitting a failure in the check, which is traced back...