Will Yardley

@TwizzyDizzy if you want to proceed with this one, could you rebase + resolve the conflicts?

Not sure how https://github.com/voxpupuli/puppet-nginx/blob/master/spec/defines/resource_server_spec.rb#L1197-L1227 are passing as of now, since they're not matching the single quotes. Does #992 resolve this for you? (note that if you're not using git, you...

@bryangwilliam I know it's in an odd spot, but check out https://github.com/voxpupuli/puppet-nginx/blob/master/.github/CONTRIBUTING.md (and all files in that directory). There is a bit of work involved in getting the tests setup,...

@luisbrandao: In the medium term, this probably should get fixed in https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/package/redhat.pp#L27-L37 I think there are some old acceptance tests for Amazon Linux, but not sure if they're up-to-date. Is...

@JayH5: you have any thoughts about this one? I’d rather not hard-code env in here, and in the past, setting it in `environment_variables` (default updated in #694) seemed to work....

`LANG` would work too, I just feel like `LC_ALL` is a little narrower. It’s already supposed to be defaulted in `environment_variables`- @rick-pri - you’re not setting that in your Puppet...

And FWIW, setting the locale correctly on the instance itself _should_ fix the problem. However, this affects enough users that we still need to set some kind of default.

It's because Rabbitmq's client tools seem to have problems with the language being set a certain way at the system level. While this really is more of a system config...

I totally agree! At the least, the module should give a more correct (and useful) warning in cases where this causes problems. Or maybe there's a way to see if...

btw, we're hoping to start work on documenting the main class in #941