Will Yardley

Results 284 comments of Will Yardley

Did you get this working, and if so, do you have a specfile? FWIW, this is how I approached it in the specfile I used for the cloud-aws plugin: https://github.com/wyardley/elasticsearch-plugin-cloud-aws-rpm/blob/master/elasticsearch-plugin-cloud-aws.spec...

I would say if you're squash merging that it can actually get more messy / muddy the waters when the commits all have this format. That said, this feature could...

This action _already_ supports validating a single commit in the case where there’s only one. I think the request here is to be able to validate _each_ commit of a...

> in my project we use rebase merges without squashing to preserve a linear history Agreed. This (or a merge commit into trunk when not using a multi branch gitflow...

If I hard-code to true in the current version, I get the expected set of releases, but now don't see any actual entries for the commits between tags. I think...

https://github.com/gavinbunney/terraform-provider-kubectl/issues/92 mentions it should be mostly fix. https://github.com/fluxcd/terraform-provider-flux/pull/283 suggests using `ignore_fields` to ignore `status` and `metadata`. I haven't had to do that for a while, but have been seeing some...

@khaefeli I do think this can be supported with the existing interface by using the features that allow setting arbitrary parameters. It looks like most of these directives can go...

You know, I had always thought that it actually _was_ the opposite already (embarrassing, because I'm pretty sure I did some updates related to that feature). I agree that this...

This turned out to be a much bigger headache than I thought it would be; that said, there is #1105 available for review. I'll see if I can get some...

I agree that it would be great if a lot of the logic and templating could be made more generic. Also, the handling of resources that can be multiple types...