puppet-nginx icon indicating copy to clipboard operation
puppet-nginx copied to clipboard

Wrong repo path in amazon linux

Open luisbrandao opened this issue 7 years ago • 1 comments

Hello,

We are making a recipe for a server with amazon linux and we run into a problem. this module is generating a bad repo url based on the fact os => release => major

os => {
  architecture => "x86_64",
  family => "RedHat",
  hardware => "x86_64",
  name => "Amazon",
  release => {
    full => "2016.09",
    major => "2016",
    minor => "09"
  },

the url is: http://nginx.org/packages/rhel/2016/x86_64/repodata/repomd.xml

should be http://nginx.org/packages/rhel/6/x86_64/repodata/repomd.xml

and, if you fix that by hand, it conflicts with files from amazon repo.

luisbrandao avatar Mar 13 '17 20:03 luisbrandao

@luisbrandao: In the medium term, this probably should get fixed in https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/package/redhat.pp#L27-L37 I think there are some old acceptance tests for Amazon Linux, but not sure if they're up-to-date. Is there a mapping somewhere of versions, and should it use rhel or centos repos?

If you can provide a PR as a starting point, great; if not, I can try to take a stab at it when I have a second, but would need a bit more detail on the exact version mapping...

wyardley avatar Apr 11 '17 06:04 wyardley